re: Which type of vise is best for an old-timey bench?

Sorry Stumpy, you asked a question which I didn’t answer. I think the type of vise would be determined by the type of work being done. For example the Moxon type vice is great for holding stuff like chair bottoms and such while a leg vice might be better for long panels or boards. I guess a leg vice or a hook like in your picture above with a portable Moxon would probably the most flexible combination.